Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ratings): Rewrite tests to make them easier to maintain #178

Merged
merged 5 commits into from
Oct 10, 2023
Merged

fix(ratings): Rewrite tests to make them easier to maintain #178

merged 5 commits into from
Oct 10, 2023

Conversation

olivierperez
Copy link
Contributor

Changes description 🧑‍💻

Fix 2 edge cases of last ratings stars algorithm.

Context 🤔

In the previous change two edge cases wasn't handled: x.245f and x.755f. In both cases it shows an Empty star icon.

Closes #175 again

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Same as #176

Other info 👋

I'm sorry I missed this point on previous fix.

@olivierperez olivierperez requested review from ManonPolle and a team as code owners October 10, 2023 08:41
ManonPolle
ManonPolle previously approved these changes Oct 10, 2023
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/980c14c1-e160-4793-a2b1-dea675510c59/artifact/f29785e32cf26e8f/p/ab53ee5c65cec5c458a433d892b20717

@ManonPolle ManonPolle merged commit 34ffb22 into Decathlon:main Oct 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(ratings): Ratings around half value are wrongly choosen
3 participants
@olivierperez @dktbitrise @ManonPolle